Skip to content

Generalize XObject API and simplify CI#13

Merged
vitormattos merged 4 commits into
mainfrom
feat/generalize-xobject-template
May 28, 2026
Merged

Generalize XObject API and simplify CI#13
vitormattos merged 4 commits into
mainfrom
feat/generalize-xobject-template

Conversation

@vitormattos
Copy link
Copy Markdown
Member

Scope

  • Change scope and impact are clearly described
    • Generalizes the package away from signature-specific integration by consolidating on XObjectPayloadAdapter
    • Updates docs, fixtures, tests, and package metadata to describe reusable Form XObject output instead of signature-only behavior
    • Simplifies CI by switching the minimum coverage gate to irongut/CodeCoverageSummary and removing the ad hoc dependency-license workflow/script

Evidence

  • Tests added/updated
    • Added tests/Integration/XObjectRenderingScenarioTest.php
    • Added tests/Unit/Integration/XObjectPayloadAdapterTest.php
    • Replaced signature-specific fixtures/tests with generic XObject scenarios
  • Relevant checks executed
    • docker compose run --rm -e XDEBUG_MODE=coverage php vendor-bin/phpunit/vendor/phpunit/phpunit/phpunit --coverage-text --coverage-clover=build/coverage/clover.xml --coverage-cobertura=build/coverage/cobertura.xml --coverage-html=build/coverage/html66 tests, 237 assertions, 99.24% line coverage
    • docker compose run --rm php composer lint
    • docker compose run --rm php composer run bc:check

Performance

  • Performance impact assessed
  • Benchmark threshold still green
    • docker compose run --rm php composer run performance:checkiterations=200 avg_ms=0.1832 peak_kb=0

Compliance

  • DCO sign-off in all commits
  • REUSE/SPDX metadata preserved
  • License compatibility reviewed
    • No new dependencies were introduced in this change set

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos merged commit 55d0193 into main May 28, 2026
23 of 24 checks passed
@vitormattos vitormattos deleted the feat/generalize-xobject-template branch June 1, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant